Skip to content

feat: add C ndarray API and refactor blas/ext/base/dsortins #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Planeshifter merged 9 commits into from
Feb 5, 2025
Merged

feat: add C ndarray API and refactor blas/ext/base/dsortins #5028

Planeshifter merged 9 commits into from
Feb 5, 2025

Conversation

@0PrashantYadav0
Copy link
Member

@0PrashantYadav0 0PrashantYadav0 commented Feb 2, 2025 •
edited
Loading

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor blas/ext/base/dsortins

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@0PrashantYadav0
feat: add C ndarray interface and refactor implementation
5e251fe 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Feb 2, 2025
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 2, 2025

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 2, 2025
@0PrashantYadav0
fix: correct argument order in dsortins function and example
3adb6a6 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 2, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 2, 2025
@0PrashantYadav0
chore: updated copyright year
56a51b2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: failed
---
@0PrashantYadav0
fix: remove return statement in stdlib_strided_dsortins function
19b04e0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: failed
---
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 2, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Feb 2, 2025
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 2, 2025

@kgryte @headlessNode @aayush0325 will you please help me to resolve the error in github cli.

kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 3, 2025
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Feb 3, 2025
@0PrashantYadav0
fix: correct argument types and improve parameter descriptions in dso…
9bf0b3c 
…rtins functions

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsortins $\color{green}443/443$
$\color{green}+100.00\%$ 		$\color{green}41/41$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}443/443$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0 0PrashantYadav0 mentioned this pull request Feb 3, 2025
Open
1 task
headlessNode
headlessNode reviewed Feb 3, 2025
View reviewed changes
@headlessNode
Copy link
Member

headlessNode commented Feb 4, 2025

@0PrashantYadav0 I just noticed, the JS examples. You will need to update the JS example in the README.md and examples/index.js

@0PrashantYadav0
chore: updated files according to code review
0a58419 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 4, 2025

@headlessNode Thank you for your review. I have updated everything. Please review and merge this pr.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 4, 2025
headlessNode
headlessNode requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@headlessNode headlessNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart these two suggestions, LGTM.

@headlessNode headlessNode removed the Needs Review A pull request which needs code review. label Feb 4, 2025
@0PrashantYadav0
fix: remove API_SUFFIX macro in dsortins examples and benchmarks for …
5816d5f 
…clarity

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 4, 2025
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Feb 4, 2025
Planeshifter
Planeshifter approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0PrashantYadav0 for your contribution and @kgryte & @headlessNode for reviews!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 5, 2025

PR Commit Message

feat: add C ndarray API and refactor `blas/ext/base/dsortins`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5028

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Muhammad Haris <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d924c8d into stdlib-js:develop Feb 5, 2025
46 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@0PrashantYadav0 @stdlib-bot @saurabhraghuvanshii
feat: add C ndarray API and refactor blas/ext/base/dsortins
1086768 
PR-URL: stdlib-js#5028

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Muhammad Haris <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@0PrashantYadav0 @stdlib-bot @ShabiShett07
feat: add C ndarray API and refactor blas/ext/base/dsortins
c75aad1 
PR-URL: stdlib-js#5028

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Muhammad Haris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@headlessNode headlessNode headlessNode approved these changes

@gunjjoshi gunjjoshi Awaiting requested review from gunjjoshi

@kgryte kgryte Awaiting requested review from kgryte

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@0PrashantYadav0 @stdlib-bot @headlessNode @Planeshifter @kgryte @gunjjoshi